Move unusual character block logic to a helper function

Move unusual character block logic to a helper function

BUG=
NOTRY=true
R=msw

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276776

[msw, 2014-06-10 18:03:15]

Can you duplicate and port RenderTextTest.Win_BreakRunsByUnicodeBlocks to RTHB?

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_harfb...
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_harfb...
ui/gfx/render_text_harfbuzz.cc:294: run_break = run_start + iter.array_pos();
Just return run_start + iter.array_pos() here.

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_win.cc
File ui/gfx/render_text_win.cc (right):

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_win.c...
ui/gfx/render_text_win.cc:281: run_break = run_start + iter.array_pos();
ditto

[ckocagil, 2014-06-11 07:49:37]

Added the test.

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_harfb...
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_harfb...
ui/gfx/render_text_harfbuzz.cc:294: run_break = run_start + iter.array_pos();
On 2014/06/10 18:03:15, msw wrote:
> Just return run_start + iter.array_pos() here.

Done.

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_win.cc
File ui/gfx/render_text_win.cc (right):

https://codereview.chromium.org/324983002/diff/20001/ui/gfx/render_text_win.c...
ui/gfx/render_text_win.cc:281: run_break = run_start + iter.array_pos();
On 2014/06/10 18:03:15, msw wrote:
> ditto

Done.

[msw, 2014-06-11 07:59:31]

lgtm!

[ckocagil, 2014-06-11 13:30:58]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:33:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/324983002/60001

[ckocagil, 2014-06-11 14:29:35]

The CQ bit was unchecked by ckocagil@chromium.org

[ckocagil, 2014-06-12 16:12:12]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:17:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/324983002/60001

[ckocagil, 2014-06-12 19:04:52]

The CQ bit was unchecked by ckocagil@chromium.org

[ckocagil, 2014-06-12 19:05:02]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-06-12 19:07:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/324983002/60001

[commit-bot: I haz the power, 2014-06-12 19:40:29]

Change committed as 276776