Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 324963007: GN: Add all_blink target (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw, abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Visibility:
Public.

Description

GN: Add all_blink target This is the GN equivalent of public/all.gyp's all_blink target which defines all test targets that blink contains. As more test targets start linking in the GN build they should be added to this file. For now, this just includes wtf_unittests and the /platform/ and /core/ components. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M public/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
This will let us isolate the GN build's dependencies on blink to the /public/ directory ...
6 years, 6 months ago (2014-06-10 19:54:19 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-10 19:59:06 UTC) #2
jamesr
Adam - gonna CQ, but FYI (if you're interested in following GN stuff)
6 years, 6 months ago (2014-06-10 20:01:37 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-10 20:01:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/324963007/1
6 years, 6 months ago (2014-06-10 20:02:41 UTC) #5
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 6 months ago (2014-06-10 20:12:57 UTC) #6
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-10 20:34:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/324963007/1
6 years, 6 months ago (2014-06-10 20:35:07 UTC) #8
abarth-chromium
Neat! LGTM
6 years, 6 months ago (2014-06-10 21:12:46 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 21:17:31 UTC) #10
Message was sent while issue was closed.
Change committed as 175917

Powered by Google App Engine
This is Rietveld 408576698