Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 324963005: Split caching from allocation in GrClipMaskManager (Closed)

Created:
6 years, 6 months ago by krajcevski
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Split caching from allocation in GrClipMaskManager Committed: https://skia.googlesource.com/skia/+/ad1dc589cef8aebf7e14672ffdaa31c6d399675d

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -39 lines) Patch
M src/gpu/GrClipMaskManager.h View 1 chunk +10 lines, -7 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 4 chunks +39 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
krajcevski
6 years, 6 months ago (2014-06-10 17:46:45 UTC) #1
robertphillips
lgtm + 2 nits https://codereview.chromium.org/324963005/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/324963005/diff/1/src/gpu/GrClipMaskManager.cpp#newcode555 src/gpu/GrClipMaskManager.cpp:555: // There's no texture in ...
6 years, 6 months ago (2014-06-10 21:13:53 UTC) #2
krajcevski
https://codereview.chromium.org/324963005/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/324963005/diff/1/src/gpu/GrClipMaskManager.cpp#newcode555 src/gpu/GrClipMaskManager.cpp:555: // There's no texture in the cache. Let's try ...
6 years, 6 months ago (2014-06-10 21:23:23 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 6 months ago (2014-06-10 21:23:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/324963005/20001
6 years, 6 months ago (2014-06-10 21:24:12 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 22:06:52 UTC) #6
Message was sent while issue was closed.
Change committed as ad1dc589cef8aebf7e14672ffdaa31c6d399675d

Powered by Google App Engine
This is Rietveld 408576698