Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4546)

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 324953002: DevToolsNetworkController: support "limit throughput" network condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/chrome_devtools_manager_delegate.cc
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
index 31089eac346e7d468707b05a6dd420e7cc81ff7d..473309d4d369f19091d17bac186f4cb6adceaa9f 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
@@ -114,6 +114,8 @@ chrome::devtools::Network::emulateNetworkConditions::kParamMaximalThroughput;
scoped_refptr<DevToolsNetworkConditions> conditions;
if (offline || maximal_throughput)
conditions = new DevToolsNetworkConditions(domains, maximal_throughput);
+
+ emulate_network_conditions_client_id_ = agent_host->GetId();
UpdateNetworkState(agent_host, conditions);
return command->SuccessResponse(NULL);
}
@@ -124,12 +126,14 @@ void ChromeDevToolsManagerDelegate::UpdateNetworkState(
Profile* profile = GetProfile(agent_host);
if (!profile)
return;
- profile->GetDevToolsNetworkController()->SetNetworkState(
- agent_host->GetId(), conditions);
+ profile->GetDevToolsNetworkController()->SetNetworkState(conditions);
}
void ChromeDevToolsManagerDelegate::OnDevToolsStateChanged(
content::DevToolsAgentHost* agent_host,
bool attached) {
- UpdateNetworkState(agent_host, scoped_refptr<DevToolsNetworkConditions>());
+ if (agent_host->GetId() == emulate_network_conditions_client_id_) {
+ emulate_network_conditions_client_id_ = std::string();
+ UpdateNetworkState(agent_host, scoped_refptr<DevToolsNetworkConditions>());
+ }
}
« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.h ('k') | chrome/browser/devtools/devtools_network_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698