Specially handle the key of the LoadKeyed and StoreKeyed instruction for x32 port.

Specially handle the key of the LoadKeyed and StoreKeyed instruction for x32 port.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21826

[haitao.feng, 2014-06-10 10:03:23]

PTAL.

[Toon Verwaest, 2014-06-12 08:54:25]

https://codereview.chromium.org/324913002/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/324913002/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:268: if (instr->IsLoadKeyed() ||
instr->IsStoreKeyed()) {
Given that this code is only relevant for Load/StoreKeyed, can we move this code
into the body of those instructions rather than here? Just add a helper method
if they need to share code.

[haitao.feng, 2014-06-12 09:34:56]

Please take another look.

https://codereview.chromium.org/324913002/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/324913002/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:268: if (instr->IsLoadKeyed() ||
instr->IsStoreKeyed()) {
On 2014/06/12 08:54:25, Toon Verwaest wrote:
> Given that this code is only relevant for Load/StoreKeyed, can we move this
code
> into the body of those instructions rather than here? Just add a helper method
> if they need to share code.

Done.

[Toon Verwaest, 2014-06-12 10:08:35]

lgtm

[haitao.feng, 2014-06-13 02:20:16]

Committed patchset #3 manually as r21826.