Remoes X11 dependency in InputMethodEngine.

chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
index e71a63342d72f7ba6fcf13c6820d681cfafc41d7..80b139417901edd397a6de5e7a979a00013a3b68 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
@@ -279,7 +279,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,
     SCOPED_TRACE("KeyDown, Ctrl:Yes, alt:No, Shift:No, Caps:No");
     KeyEventDoneCallback callback(false);
     const std::string expected_value =
-        "onKeyEvent::keydown:a:KeyA:true:false:false:false";
+        "onKeyEvent::keydown:\x01:KeyA:true:false:false:false";

[sadrul, 2014/06/12 11:17:14]

Is there a reason for the test expectations to change from removing the X11
dependencies? Does this mean this CL changes some existing functionality? Can
you explain that change in the CL description?

[Shu Chen, 2014/06/12 13:55:30]

The original tests' expectations were wrong. The original logics in
GetExtensionKeyboardEventFromKeyEvent() uses ui::XKeysymForWindowsKeyCode()
method to get the wrong key string which only considers the SHIFT modifier. 
As you can see the below CAPS+A test case, the "key" should be "A" instead of
"a".

This cl uses event.GetCharacter() which can get the correct "key".

     ExtensionTestMessageListener keyevent_listener(expected_value, false);
 
     ui::KeyEvent key_event(ui::ET_KEY_PRESSED,
@@ -336,7 +336,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,
     SCOPED_TRACE("KeyDown, Ctrl:No, alt:No, Shift:No, Caps:Yes");
     KeyEventDoneCallback callback(false);
     const std::string expected_value =
-        "onKeyEvent::keydown:a:KeyA:false:false:false:true";
+        "onKeyEvent::keydown:A:KeyA:false:false:false:true";
     ExtensionTestMessageListener keyevent_listener(expected_value, false);
 
     ui::KeyEvent key_event(ui::ET_KEY_PRESSED,
@@ -355,7 +355,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,
     SCOPED_TRACE("KeyDown, Ctrl:Yes, alt:Yes, Shift:No, Caps:No");
     KeyEventDoneCallback callback(false);
     const std::string expected_value =
-        "onKeyEvent::keydown:a:KeyA:true:true:false:false";
+        "onKeyEvent::keydown:\x01:KeyA:true:true:false:false";
     ExtensionTestMessageListener keyevent_listener(expected_value, false);
 
     ui::KeyEvent key_event(ui::ET_KEY_PRESSED,
@@ -374,7 +374,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,
     SCOPED_TRACE("KeyDown, Ctrl:No, alt:No, Shift:Yes, Caps:Yes");
     KeyEventDoneCallback callback(false);
     const std::string expected_value =
-        "onKeyEvent::keydown:A:KeyA:false:false:true:true";
+        "onKeyEvent::keydown:a:KeyA:false:false:true:true";
     ExtensionTestMessageListener keyevent_listener(expected_value, false);
 
     ui::KeyEvent key_event(ui::ET_KEY_PRESSED,