ui/base/ime/chromeos/ime_keymap.h - Issue 324903002: Remoes X11 dependency in InputMethodEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/chromeos/ime_keymap.h

Issue 324903002: Remoes X11 dependency in InputMethodEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/chromeos/ime_keymap.h

diff --git a/ui/base/ime/chromeos/ime_keymap.h b/ui/base/ime/chromeos/ime_keymap.h

index 863efb5f5e8c425953bf55b331acfbe82ed827b9..7d41b3f323ddabc8c67a3914b901dcbf03273883 100644

--- a/ui/base/ime/chromeos/ime_keymap.h

+++ b/ui/base/ime/chromeos/ime_keymap.h

@@ -8,12 +8,12 @@

#include <string>

#include "base/basictypes.h"

#include "ui/base/ui_base_export.h"

+#include "ui/events/keycodes/keyboard_codes.h"

namespace ui {

-// Translates the key value from an X11 key value to key value string

-// visible from javascript.

-UI_BASE_EXPORT std::string FromXKeycodeToKeyValue(int keyval);

+// Translates the DOM4 key code string to ui::KeyboardCode.

+UI_BASE_EXPORT KeyboardCode DomKeycodeToKeyboardCode(const std::string& code);

} // namespace ui