chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc - Issue 324903002: Remoes X11 dependency in InputMethodEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 324903002: Remoes X11 dependency in InputMethodEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

index e71a63342d72f7ba6fcf13c6820d681cfafc41d7..32729208189eccf5f9cab10504fe2836793d0d6b 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

@@ -336,7 +336,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

SCOPED_TRACE("KeyDown, Ctrl:No, alt:No, Shift:No, Caps:Yes");

KeyEventDoneCallback callback(false);

const std::string expected_value =

- "onKeyEvent::keydown:a:KeyA:false:false:false:true";

+ "onKeyEvent::keydown:A:KeyA:false:false:false:true";

ExtensionTestMessageListener keyevent_listener(expected_value, false);

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

@@ -374,7 +374,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

SCOPED_TRACE("KeyDown, Ctrl:No, alt:No, Shift:Yes, Caps:Yes");

KeyEventDoneCallback callback(false);

const std::string expected_value =

- "onKeyEvent::keydown:A:KeyA:false:false:true:true";

+ "onKeyEvent::keydown:a:KeyA:false:false:true:true";

ExtensionTestMessageListener keyevent_listener(expected_value, false);

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | ui/base/ime/chromeos/character_composer.cc » ('j') | no next file with comments »