ui/base/ime/chromeos/ime_keymap.h - Issue 324903002: Remoes X11 dependency in InputMethodEngine.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/ime/chromeos/ime_keymap.h

Issue 324903002: Remoes X11 dependency in InputMethodEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_BASE_IME_CHROMEOS_IME_KEYMAP_H_	5 #ifndef UI_BASE_IME_CHROMEOS_IME_KEYMAP_H_

6 #define UI_BASE_IME_CHROMEOS_IME_KEYMAP_H_	6 #define UI_BASE_IME_CHROMEOS_IME_KEYMAP_H_

7	7

8 #include <string>	8 #include <string>

9 #include "base/basictypes.h"	9 #include "base/basictypes.h"

10 #include "ui/base/ui_base_export.h"	10 #include "ui/base/ui_base_export.h"

	11 #include "ui/events/keycodes/keyboard_codes.h"

11	12

12 namespace ui {	13 namespace ui {

13	14

14 // Translates the key value from an X11 key value to key value string	15 // Translates the DOM4 key code string to ui::KeyboardCode.

15 // visible from javascript.	16 UI_BASE_EXPORT KeyboardCode DomCode2KeyboardCode(const std::string& code);
	Yuki 2014/06/16 08:30:46 Our naming policy is to not use "2" meaning "To". Our naming policy is to not use "2" meaning "To". Use "To". Do not care the length (especially 80 columns rule) too much. Clear naming is much more important than 80 columns rule. I'd prefer DomKeycode to DomCode because there are many codes in DOM world and it's ambiguous. Shu Chen 2014/06/16 08:43:14 Done. Show quoted text On 2014/06/16 08:30:46, Yuki wrote: > Our naming policy is to not use "2" meaning "To". Use "To". > Do not care the length (especially 80 columns rule) too much. Clear naming is > much more important than 80 columns rule. > > I'd prefer DomKeycode to DomCode because there are many codes in DOM world and > it's ambiguous. Done.
16 UI_BASE_EXPORT std::string FromXKeycodeToKeyValue(int keyval);

17	17

18 } // namespace ui	18 } // namespace ui

19	19

20 #endif // UI_BASE_IME_CHROMEOS_IME_KEYMAP_H_	20 #endif // UI_BASE_IME_CHROMEOS_IME_KEYMAP_H_

OLD	NEW

« no previous file with comments | « ui/base/ime/chromeos/character_composer_unittest.cc ('k') | ui/base/ime/chromeos/ime_keymap.cc » ('j') | ui/base/ime/chromeos/ime_keymap.cc » ('J')