Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 324883006: Cleanup: Use PostTaskAndReplyWithResults instead of passing callbacks around in downloads code. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
asanka
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Visibility:
Public.

Description

Cleanup: Use PostTaskAndReplyWithResults instead of passing callbacks around in downloads code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 4 chunks +27 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
6 years, 6 months ago (2014-06-11 05:54:46 UTC) #1
asanka
lgtm
6 years, 6 months ago (2014-06-11 13:09:13 UTC) #2
asanka
lgtm
6 years, 6 months ago (2014-06-11 13:09:15 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-11 18:32:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/324883006/1
6 years, 6 months ago (2014-06-11 18:36:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:24:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:31:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38004) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19632)
6 years, 6 months ago (2014-06-11 21:31:21 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-12 05:05:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/324883006/1
6 years, 6 months ago (2014-06-12 05:09:19 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 10:10:23 UTC) #11
Message was sent while issue was closed.
Change committed as 276613

Powered by Google App Engine
This is Rietveld 408576698