Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 324883002: Merge 275861 "Revert 274770 "Ensure that in-process plugins can'..." (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 275861 "Revert 274770 "Ensure that in-process plugins can'..." > Revert 274770 "Ensure that in-process plugins can't destroy them..." > > > Ensure that in-process plugins can't destroy themselves by closing a URLLoader > > > > Previously in-process plugins could close the main URLLoader, which could result > > destruction of themselves. This only happens in-process because calling > > URLLoader.Close() results in synchronously calling in to blink, whereas the > > call is asynchronous due to IPC when OOP. > > > > This is fixed here by adding a hack to the in-process router. We should probably > > post every message to the message loop, but there is a chance this might break > > something and we will be removing in-process plugins altogether soon. > > > > There are also two other related bugs this fixes: > > 1) The PepperPluginInstanceImpl::DidDataFromWebURLResponse could be called > > after PepperPluginInstanceImpl::Delete() has been run, in which case the > > plugin instance may also be destroyed, so we should not run HandleDocumentLoad > > in that case. > > 2) The instance may be destroyed before the PepperURLLoaderHost so we need > > to check if it is null. > > > > BUG=372548 > > > > Review URL: https://codereview.chromium.org/314603002 > > TBR=raymes@chromium.org > > Review URL: https://codereview.chromium.org/321933002 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -42 lines) Patch
M content/renderer/pepper/pepper_in_process_router.cc View 1 chunk +6 lines, -34 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_url_loader_host.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-10 03:37:19 UTC) #1
amineer_google
6 years, 6 months ago (2014-06-10 03:37:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r275930.

Powered by Google App Engine
This is Rietveld 408576698