Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 324873002: Removed debug logging to track flaky test. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Removed debug logging to track flaky test. The flakiness in PlatformAppBrowserTest.AppWindowAdjustBoundsToBeVisibleOnScreen has been fixed, so the logging is no longer needed. BUG=377754 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
benwells
6 years, 6 months ago (2014-06-10 03:01:44 UTC) #1
Matt Giuca
lgtm
6 years, 6 months ago (2014-06-10 03:03:17 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-10 03:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/324873002/1
6 years, 6 months ago (2014-06-10 03:13:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 17:54:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 18:24:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/161189)
6 years, 6 months ago (2014-06-10 18:24:46 UTC) #7
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-11 06:33:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/324873002/1
6 years, 6 months ago (2014-06-11 06:34:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 07:54:52 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 09:12:45 UTC) #11
Message was sent while issue was closed.
Change committed as 276314

Powered by Google App Engine
This is Rietveld 408576698