runtime/vm/coverage.cc - Issue 324843004: Significantly improve performance of code coverage tool by precomputing a map token_pos->line numbe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/coverage.cc

Issue 324843004: Significantly improve performance of code coverage tool by precomputing a map token_pos->line numbe… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/coverage.cc

===================================================================

--- runtime/vm/coverage.cc (revision 37119)

+++ runtime/vm/coverage.cc (working copy)

@@ -88,6 +88,8 @@

function ^= functions.At(i);

JSONObject jsobj(&jsarr);

script = function.script();

+ // Makes token_pos to line-number lookup faster.

+ script.ComputeTokenPosToLineNumberArray();

Ivan Posva 2014/06/10 00:14:58 As discussed we might want to cache this array onl

saved_url = script.url();

jsobj.AddProperty("source", saved_url.ToCString());

jsobj.AddProperty("script", script);

« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »