Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 324813006: Add known_incompatible.py items to the blacklist in deps_whitelist.py (Closed)

Created:
6 years, 6 months ago by hjd
Modified:
6 years, 6 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add known_incompatible.py items to the blacklist in deps_whitelist.py This allows the android_aosp bot to better model the behavior of the automerger. We add a 'android_rsync_build' method to android_webview/buildbot/deps_whitelist.py which returns all black listed paths (not just blacklisted deps) and has a list output format (as opposed to dictionary format of the other methods). Then we add the 'all_incompatible_directories' option to android_webview/tools/webview_licenses.py to get all the incompatible directories rather that just the unknown ones. This exposes the same code the automeger uses directly as a command line argument. BUG=311868 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276639

Patch Set 1 #

Patch Set 2 : Fix path. #

Patch Set 3 : Remove leading dot. #

Total comments: 7

Patch Set 4 : Update for feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -11 lines) Patch
M android_webview/buildbot/deps_whitelist.py View 1 2 3 6 chunks +43 lines, -1 line 0 comments Download
M android_webview/tools/webview_licenses.py View 1 2 3 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mkosiba (inactive)
LGTM, over to Mikhail for license check https://codereview.chromium.org/324813006/diff/40001/android_webview/buildbot/deps_whitelist.py File android_webview/buildbot/deps_whitelist.py (right): https://codereview.chromium.org/324813006/diff/40001/android_webview/buildbot/deps_whitelist.py#newcode70 android_webview/buildbot/deps_whitelist.py:70: self._uneeded_for_building_android = ...
6 years, 6 months ago (2014-06-11 09:38:38 UTC) #1
mnaganov (inactive)
lgtm
6 years, 6 months ago (2014-06-11 09:52:47 UTC) #2
hjd
Fixed the names and the path special case. https://codereview.chromium.org/324813006/diff/40001/android_webview/buildbot/deps_whitelist.py File android_webview/buildbot/deps_whitelist.py (right): https://codereview.chromium.org/324813006/diff/40001/android_webview/buildbot/deps_whitelist.py#newcode70 android_webview/buildbot/deps_whitelist.py:70: self._uneeded_for_building_android ...
6 years, 6 months ago (2014-06-11 09:59:25 UTC) #3
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 6 months ago (2014-06-11 10:53:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/324813006/60001
6 years, 6 months ago (2014-06-11 10:56:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:36:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:52:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19668)
6 years, 6 months ago (2014-06-11 21:52:10 UTC) #8
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 6 months ago (2014-06-12 08:26:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/324813006/60001
6 years, 6 months ago (2014-06-12 08:28:28 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:39:28 UTC) #11
Message was sent while issue was closed.
Change committed as 276639

Powered by Google App Engine
This is Rietveld 408576698