Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 324813002: Convert raw pointer to PassOwnPtr for EventFactoryBase (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Convert raw pointer to PassOwnPtrfor EventFactoryBase. This should avoid memory leaks when the program exits gracefully. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175887

Patch Set 1 #

Patch Set 2 : Fix debug build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M Source/core/Init.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/EventFactory.h View 1 chunk +10 lines, -1 line 0 comments Download
M Source/modules/EventModulesFactory.h View 1 chunk +6 lines, -1 line 0 comments Download
M Source/modules/InitModules.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
c.shu
6 years, 6 months ago (2014-06-09 22:39:47 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-09 23:18:23 UTC) #2
Inactive
lgtm2
6 years, 6 months ago (2014-06-09 23:59:21 UTC) #3
c.shu
On 2014/06/09 23:59:21, Chris Dumez wrote: > lgtm2 thanks, guys.
6 years, 6 months ago (2014-06-10 00:09:09 UTC) #4
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-10 00:09:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/324813002/20001
6 years, 6 months ago (2014-06-10 00:09:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 01:06:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 02:37:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11350)
6 years, 6 months ago (2014-06-10 02:37:26 UTC) #9
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-10 11:34:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/324813002/20001
6 years, 6 months ago (2014-06-10 11:35:21 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 11:35:55 UTC) #12
Message was sent while issue was closed.
Change committed as 175887

Powered by Google App Engine
This is Rietveld 408576698