Issue 324773002: Remove base/memory/scoped_handle.h

Issue 324773002: Remove base/memory/scoped_handle.h (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, jam, gavinp+memory_chromium.org, dcheng, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, eroman, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove base/memory/scoped_handle.h Move the existing 8 users of ScopedStdioHandle (the only thing in this header) to using ScopedFILE like most other code. Remove the dead references to this header from other files in the codebase. R=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276071

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -84 lines)			Patch
M	base/base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	base/memory/scoped_handle.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
M	base/win/scoped_handle.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/component_updater/component_patcher_operation.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/component_updater/component_unpacker.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_creator.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/external_registry_loader_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_unpacker.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_downloader.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/utility/extensions/unpacker.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/gpu/media/dxva_video_decode_accelerator.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/plugin/plugin_channel.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/plugin/webplugin_proxy.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/plugin/webplugin_proxy.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/android/keystore_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/net_log_logger.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/socket/ssl_client_socket_openssl_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/base/vlog_net_log.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/clipboard/clipboard_util_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_provider_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/dragdrop/os_exchange_data_win_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/native_theme/native_theme_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r276071.

Expand Messages | Collapse Messages