Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 324753002: Fix ownership bug with ViewObserver::OnViewInputEvent (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Fix ownership bug with ViewObserver::OnViewInputEvent It needs to take a const EventPtr& otherwise the first observer owns the event and all others get NULL. BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276012

Patch Set 1 #

Patch Set 2 : no pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M mojo/examples/embedded_app/embedded_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/view_observer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
sky
6 years, 6 months ago (2014-06-09 20:28:01 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-09 20:34:18 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-09 20:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/324753002/1
6 years, 6 months ago (2014-06-09 20:36:45 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-09 21:47:49 UTC) #5
sky
The CQ bit was unchecked by sky@chromium.org
6 years, 6 months ago (2014-06-09 21:48:13 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-09 21:55:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/324753002/20001
6 years, 6 months ago (2014-06-09 21:58:42 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 11:41:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 13:30:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150299)
6 years, 6 months ago (2014-06-10 13:30:36 UTC) #11
sky
6 years, 6 months ago (2014-06-10 13:40:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r276012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698