Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 324733002: Add a layout test for iframe flicker due to overflow scroll promotion (Closed)

Created:
6 years, 6 months ago by Ian Vollick
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Visibility:
Public.

Description

Add a layout test for iframe flicker due to overflow scroll promotion This test checks that the composited layer tree is updated immediately after the inner iframe becomes composited due to an accelerated overflow scrolling layer. I have confirmed that this test fails without Ojan's change to give all RenderParts render layers (this CL marks composited iframes as self painting immediately rather than after a style update allowing the GraphicsLayerUpdater to stitch in the subframe's graphics layer tree right away) -- https://codereview.chromium.org/302083002 R=ojan@chromium.org BUG=379097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175817

Patch Set 1 : . #

Total comments: 7

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/compositing/iframes/composited-iframe-transition-flicker-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ian Vollick
6 years, 6 months ago (2014-06-09 16:56:23 UTC) #1
ojan
lgtm Please fix the rAF thing before committing. https://codereview.chromium.org/324733002/diff/20001/LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html File LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html (right): https://codereview.chromium.org/324733002/diff/20001/LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html#newcode2 LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html:2: <iframe ...
6 years, 6 months ago (2014-06-09 17:42:38 UTC) #2
Ian Vollick
https://codereview.chromium.org/324733002/diff/20001/LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html File LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html (right): https://codereview.chromium.org/324733002/diff/20001/LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html#newcode2 LayoutTests/compositing/iframes/composited-iframe-transition-flicker.html:2: <iframe id="frame" srcdoc="<style>input { width: 100px; }</style><input type='text' id='input' ...
6 years, 6 months ago (2014-06-09 18:35:57 UTC) #3
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-09 18:36:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/324733002/40001
6 years, 6 months ago (2014-06-09 18:36:24 UTC) #5
Ian Vollick
The CQ bit was unchecked by vollick@chromium.org
6 years, 6 months ago (2014-06-09 18:36:28 UTC) #6
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-09 18:40:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/324733002/60001
6 years, 6 months ago (2014-06-09 18:40:43 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 19:44:30 UTC) #9
Message was sent while issue was closed.
Change committed as 175817

Powered by Google App Engine
This is Rietveld 408576698