Issue 32473007: MIPS: Inline number to string conversion for string addition into BinaryOp(Stub).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 32473007: MIPS: Inline number to string conversion for string addition into BinaryOp(Stub). (Closed)

Created:
7 years, 2 months ago by palfia

Modified:
7 years, 2 months ago

Reviewers:
kisg, Paul Lind, Benedikt Meurer, danno, kilvadyb

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Inline number to string conversion for string addition into BinaryOp(Stub). Port r17290 (b5fabb92) Original commit message: This fixes a performance regression that was caused by converting the BinaryOpStub to a Hydrogen code stub. It also fixes a leftover TODO wrt. the handling of Number*String or String*Number versions of the stub. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=17304

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/mips/code-stubs-mips.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

palfia

7 years, 2 months ago (2013-10-21 22:16:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17304 (presubmit successful).

Expand Messages | Collapse Messages