Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 324713002: Enable FastMobileScrolling runtime flag for Android to match the (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
Reviewers:
Avi (use Gerrit), piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable FastMobileScrolling runtime flag for Android to match the command-line flag. The effort needs to be done in 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. This is the 2nd set of changes. BUG=381391 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
c.shu
6 years, 6 months ago (2014-06-09 14:53:52 UTC) #1
Avi (use Gerrit)
lgtm stamp
6 years, 6 months ago (2014-06-09 15:09:24 UTC) #2
c.shu
On 2014/06/09 15:09:24, Avi wrote: > lgtm > > stamp thank you.
6 years, 6 months ago (2014-06-09 15:10:35 UTC) #3
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-09 15:10:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/324713002/1
6 years, 6 months ago (2014-06-09 15:11:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 07:17:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 13:07:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150267)
6 years, 6 months ago (2014-06-10 13:07:10 UTC) #8
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-10 14:44:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/324713002/1
6 years, 6 months ago (2014-06-10 14:47:03 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 18:06:11 UTC) #11
Message was sent while issue was closed.
Change committed as 276077

Powered by Google App Engine
This is Rietveld 408576698