Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 324683002: Get rid of WebInspector.TracingTimelineModel.Events.TracingComplete event (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Get rid of WebInspector.TracingTimelineModel.Events.TracingComplete event WebInspector.TimelineModel.Events.RecordingStopped is sufficient. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 5 chunks +13 lines, -17 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
6 years, 6 months ago (2014-06-09 12:25:05 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-09 13:08:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/324683002/1
6 years, 6 months ago (2014-06-09 13:09:03 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 14:11:20 UTC) #4
Message was sent while issue was closed.
Change committed as 175796

Powered by Google App Engine
This is Rietveld 408576698