Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2531)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 32463003: Modify hit test masks for tabs and tab close buttons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some changes to new tests Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 0e3ac65f49e1a7de2d7780215bc68c660cfabca1..403f2bc46096a8604f443357a06427161b0fb878 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -309,7 +309,8 @@ class NewTabButton : public views::ImageButton {
protected:
// Overridden from views::View:
virtual bool HasHitTestMask() const OVERRIDE;
- virtual void GetHitTestMask(gfx::Path* path) const OVERRIDE;
+ virtual void GetHitTestMask(gfx::Path* path,
+ HitTestSource source) const OVERRIDE;
sky 2013/10/28 14:26:00 align HitTestSource with openning '(' on previous
tdanderson 2013/10/28 15:40:09 Done.
#if defined(OS_WIN)
virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
#endif
@@ -356,7 +357,7 @@ bool NewTabButton::HasHitTestMask() const {
return !tab_strip_->SizeTabButtonToTopOfTabStrip();
}
-void NewTabButton::GetHitTestMask(gfx::Path* path) const {
+void NewTabButton::GetHitTestMask(gfx::Path* path, HitTestSource source) const {
DCHECK(path);
SkScalar w = SkIntToScalar(width());

Powered by Google App Engine
This is Rietveld 408576698