chrome/browser/ui/views/tabs/tab_strip.cc - Issue 32463003: Modify hit test masks for tabs and tab close buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 32463003: Modify hit test masks for tabs and tab close buttons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc

index 1597635e01c9d223b1b7919b58134df970b0c298..fe2962e49ced3a990a99bc7d47cb82d10513cf4d 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/tab_strip.cc

@@ -309,7 +309,8 @@ class NewTabButton : public views::ImageButton {

protected:

// Overridden from views::View:

virtual bool HasHitTestMask() const OVERRIDE;

- virtual void GetHitTestMask(gfx::Path* path) const OVERRIDE;

+ virtual void GetHitTestMask(HitTestSource source,

+ gfx::Path* path) const OVERRIDE;

#if defined(OS_WIN)

virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;

#endif

@@ -356,7 +357,7 @@ bool NewTabButton::HasHitTestMask() const {

return !tab_strip_->SizeTabButtonToTopOfTabStrip();

}

-void NewTabButton::GetHitTestMask(gfx::Path* path) const {

+void NewTabButton::GetHitTestMask(HitTestSource source, gfx::Path* path) const {

DCHECK(path);

SkScalar w = SkIntToScalar(width());