Issue 3246004: Hide mac background mode prefs ui if background mode is not enabled.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3246004: Hide mac background mode prefs ui if background mode is not enabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Andrew T Wilson

Modified:
4 years ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Hide mac background mode prefs ui if background mode is not enabled. Change to Preferences.xib: Setup preferences_window_controller.mm as a referencing outlet for the background mode UI so we can hide it. BUG=53522 TEST=run chrome without --enable-background-mode, make sure associated prefs UI is not shown Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57779

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -3 lines)			Patch
M	chrome/app/nibs/Preferences.xib	View	7 chunks	+63 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages