Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 3246004: Hide mac background mode prefs ui if background mode is not enabled. (Closed)

Created:
10 years, 3 months ago by Andrew T Wilson (Slow)
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Hide mac background mode prefs ui if background mode is not enabled. Change to Preferences.xib: Setup preferences_window_controller.mm as a referencing outlet for the background mode UI so we can hide it. BUG=53522 TEST=run chrome without --enable-background-mode, make sure associated prefs UI is not shown Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M chrome/app/nibs/Preferences.xib View 7 chunks +63 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Miranda Callahan
10 years, 3 months ago (2010-08-28 01:50:37 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698