chrome/browser/download/download_shelf_context_menu.h - Issue 324593004: Windows: Add an "Open in Adobe Reader" menu item for PDF files in the download shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf_context_menu.h

Issue 324593004: Windows: Add an "Open in Adobe Reader" menu item for PDF files in the download shelf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, check AcroRd32.exe version, set/honor prefs Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | chrome/browser/download/download_shelf_context_menu.cc » ('j') | chrome/browser/download/download_shelf_context_menu.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_shelf_context_menu.h

diff --git a/chrome/browser/download/download_shelf_context_menu.h b/chrome/browser/download/download_shelf_context_menu.h

index 15b6504c7807cd63035ceca7b1ef4d7cfc9c8b6f..22b6d5a7d4761f15c804112a3564933783ddd91d 100644

--- a/chrome/browser/download/download_shelf_context_menu.h

+++ b/chrome/browser/download/download_shelf_context_menu.h

@@ -73,6 +73,13 @@ class DownloadShelfContextMenu : public ui::SimpleMenuModel::Delegate,

ui::SimpleMenuModel* GetMaybeMaliciousMenuModel();

ui::SimpleMenuModel* GetMaliciousMenuModel();

+ int GetAlwaysOpenStringId() const;

+#if defined(OS_WIN)

+ bool IsDownloadPdf() const;

+ bool CanOpenPdfInReader() const;

+#endif

// We show slightly different menus if the download is in progress vs. if the

// download has finished.

scoped_ptr<ui::SimpleMenuModel> in_progress_download_menu_model_;

@@ -87,6 +94,10 @@ class DownloadShelfContextMenu : public ui::SimpleMenuModel::Delegate,

// Used to open tabs.

content::PageNavigator* navigator_;

+#if defined(OS_WIN)

+ bool is_pdf_reader_up_to_date_;

+#endif

DISALLOW_COPY_AND_ASSIGN(DownloadShelfContextMenu);

};