Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/app/generated_resources.grd

Issue 324593004: Windows: Add an "Open in Adobe Reader" menu item for PDF files in the download shelf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, check AcroRd32.exe version, set/honor prefs Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index d081c827fd272703e2b8b33548c7abe987485e13..23c76e0ee0aa239696591bd7c0c8ccc1252421a0 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -1960,20 +1960,11 @@ Even if you have downloaded files from this website before, the website might ha
<!-- Download Context Menu Items -->
<if expr="not is_android">
<if expr="not use_titlecase">
- <if expr="is_macosx">
- <message name="IDS_DOWNLOAD_MENU_SHOW"
- desc="Mac: Show the file in the Finder, 'Show in Finder' item"
- meaning="'show in Finder' on Mac in Sentence case">
- &amp;Show in Finder
- </message>
- </if>
- <if expr="not is_macosx">
- <message name="IDS_DOWNLOAD_MENU_SHOW"
- desc="Show the file in file explorer, 'Show in folder' item"
- meaning="'show in folder' on non Mac in Sentence case">
+ <message name="IDS_DOWNLOAD_MENU_SHOW"
+ desc="Show the file in file explorer, 'Show in folder' item"
+ meaning="'show in folder' on non Mac in Sentence case">
&amp;Show in folder
- </message>
- </if>
+ </message>
<message name="IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE"
desc="Download context menu: Open when download is finished">
Open when &amp;done
@@ -2018,22 +2009,13 @@ Even if you have downloaded files from this website before, the website might ha
desc="Download context menu: Show information about interrupted downloads">
&amp;More information
</message>
- </if>
+ </if> <!-- not use_titlecase -->
<if expr="use_titlecase">
- <if expr="is_macosx">
- <message name="IDS_DOWNLOAD_MENU_SHOW"
- desc="In Title Case: Mac: Show the file in the Finder, 'Show in Finder' item"
- meaning="'show in Finder' on Mac in Title Case">
- &amp;Show in Finder
- </message>
- </if>
- <if expr="not is_macosx">
- <message name="IDS_DOWNLOAD_MENU_SHOW"
- desc="In Title Case: Show the file in file explorer, 'Show in folder' item"
- meaning="'show in folder' on non Mac in Title Case">
- &amp;Show in Folder
- </message>
- </if>
+ <message name="IDS_DOWNLOAD_MENU_SHOW"
+ desc="In Title Case: Mac: Show the file in the Finder, 'Show in Finder' item"
+ meaning="'show in Finder' on Mac in Title Case">
+ &amp;Show in Finder
+ </message>
<message name="IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE"
desc="In Title Case: Download context menu: Open when download is finished">
Open When &amp;Done
@@ -2078,6 +2060,12 @@ Even if you have downloaded files from this website before, the website might ha
desc="In Title Case: Download context menu: Show information about interrupted downloads">
&amp;More Information
</message>
+ </if> <!-- not use_titlecase -->
+ <if expr="is_win">
+ <message name="IDS_DOWNLOAD_MENU_ALWAYS_OPEN_PDF_IN_READER"
+ desc="Download context menu: Open when download using Adobe Reader">
+ Always open in Adobe Reader
+ </message>
</if>
</if>
« no previous file with comments | « no previous file | chrome/browser/download/download_prefs.h » ('j') | chrome/browser/download/download_shelf_context_menu.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698