Windows: Add an "Open in Adobe Reader" menu item for PDF files in the download shelf.

chrome/browser/download/download_shelf_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_shelf_context_menu.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/common/content_switches.h"
 #include "extensions/common/extension.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
+#if defined(OS_WIN)
+#include "chrome/browser/ui/pdf/adobe_reader_info_win.h"
+#endif
+
 using content::DownloadItem;
-using extensions::Extension;
 
 namespace {
 
 // Returns true if downloads resumption is enabled.
 bool IsDownloadResumptionEnabled() {
-  const CommandLine& command_line = *CommandLine::ForCurrentProcess();
-  return command_line.HasSwitch(switches::kEnableDownloadResumption);
+  return base::CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableDownloadResumption);
 }
 
 }  // namespace
 
 DownloadShelfContextMenu::~DownloadShelfContextMenu() {
   DetachFromDownloadItem();
 }
 
 DownloadShelfContextMenu::DownloadShelfContextMenu(
     DownloadItem* download_item,
     content::PageNavigator* navigator)
     : download_item_(download_item),
       navigator_(navigator) {
   DCHECK(download_item_);
   download_item_->AddObserver(this);
+
+#if defined(OS_WIN)
+#if defined(ENABLE_PLUGIN_INSTALLATION)

[jam, 2014/06/09 19:49:09]

nit: OS_WIN implies ENABLE_PLUGIN_INSTALLATION...

[Lei Zhang, 2014/06/12 05:04:26]

The PDF UI code we started with has defined(OS_WIN) &&
defined(ENABLE_PLUGIN_INSTALLATION), but I'm happy to simply both, as I doubt
anyone builds with OS_WIN but not ENABLE_PLUGIN_INSTALLATION.

+  is_pdf_reader_up_to_date_ = false;
+  if (IsDownloadPdf() && IsAdobeReaderDefaultPDFViewer()) {
+    AdobeReaderPluginInfo plugin_info;
+    GetAdobeReaderPluginInfo(NULL, &plugin_info);

[jam, 2014/06/09 19:49:09]

this won't work after we remove NPAPI, which is what's motivating this feature.
right now the classification of whether Reader plugin is out of date or not
comes from a json file that is part of chrome and is updated by component
updater. for this one-off use case, i think it's fine to hard code the versions
of Reader that are out-of-date in a cc file. if we really need to update it
immediately, we can do a push then.

[Lei Zhang, 2014/06/12 05:04:26]

Ok, I changed this to check the version of the reader EXE file on disk. I didn't
find a good way to get the version number out of the registry. :\

Since we have to get it from disk and we are on the UI thread here, I made
DownloadPref do a check once at initialization time and cache the result
globally.

+    is_pdf_reader_up_to_date_ =
+        plugin_info.is_installed && plugin_info.is_secure;
+  }
+#else
+  is_pdf_reader_up_to_date_ = true;
+#endif  // defined(ENABLE_PLUGIN_INSTALLATION)
+#endif  // defined(OS_WIN)
 }
 
 ui::SimpleMenuModel* DownloadShelfContextMenu::GetMenuModel() {
   ui::SimpleMenuModel* model = NULL;
 
   if (!download_item_)
     return NULL;
 
   DownloadItemModel download_model(download_item_);
   // We shouldn't be opening a context menu for a dangerous download, unless it
@@ skipping 33 matching lines @@
     case CANCEL:
       return !download_item_->IsDone();
     case TOGGLE_PAUSE:
       return !download_item_->IsDone();
     case DISCARD:
     case KEEP:
     case LEARN_MORE_SCANNING:
     case LEARN_MORE_INTERRUPTED:
       return true;
   }
+  NOTREACHED();
   return false;
 }
 
 bool DownloadShelfContextMenu::IsCommandIdChecked(int command_id) const {
   if (!download_item_)
     return false;
 
   switch (command_id) {
     case OPEN_WHEN_COMPLETE:
       return download_item_->GetOpenWhenComplete() ||
@@ skipping 15 matching lines @@
       download_item_->ShowDownloadInShell();
       break;
     case OPEN_WHEN_COMPLETE:
       download_item_->OpenDownload();
       break;
     case ALWAYS_OPEN_TYPE: {
       DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
           download_item_->GetBrowserContext());
       base::FilePath path = download_item_->GetTargetFilePath();
       if (!IsCommandIdChecked(ALWAYS_OPEN_TYPE))
         prefs->EnableAutoOpenBasedOnExtension(path);

[Lei Zhang, 2014/06/09 09:04:46]

I still need to implement some special logic to implement requirement (3),
probably with a separate pref to keep track of whether this is for .pdf + secure
reader, and resetting the checkbox if reader gets uninstalled.

       else
         prefs->DisableAutoOpenBasedOnExtension(path);
       break;
     }
     case PLATFORM_OPEN:
       DownloadItemModel(download_item_).OpenUsingPlatformHandler();
       break;
     case CANCEL:
       download_item_->Cancel(true /* Cancelled by user */);
       break;
@@ skipping 50 matching lines @@
 base::string16 DownloadShelfContextMenu::GetLabelForCommandId(
     int command_id) const {
   switch (static_cast<ContextMenuCommands>(command_id)) {
     case SHOW_IN_FOLDER:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_SHOW);
     case OPEN_WHEN_COMPLETE:
       if (download_item_ && !download_item_->IsDone())
         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN);
     case ALWAYS_OPEN_TYPE:
-      return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE);
+      return l10n_util::GetStringUTF16(GetAlwaysOpenCommandId());
     case PLATFORM_OPEN:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_PLATFORM_OPEN);
     case CANCEL:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_CANCEL);
     case TOGGLE_PAUSE:
       if (download_item_ &&
           download_item_->GetState() == DownloadItem::IN_PROGRESS &&
           !download_item_->IsPaused())
         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_PAUSE_ITEM);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_RESUME_ITEM);
@@ skipping 26 matching lines @@
 
 ui::SimpleMenuModel* DownloadShelfContextMenu::GetInProgressMenuModel() {
   if (in_progress_download_menu_model_)
     return in_progress_download_menu_model_.get();
 
   in_progress_download_menu_model_.reset(new ui::SimpleMenuModel(this));
 
   in_progress_download_menu_model_->AddCheckItemWithStringId(
       OPEN_WHEN_COMPLETE, IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE);
   in_progress_download_menu_model_->AddCheckItemWithStringId(
-      ALWAYS_OPEN_TYPE, IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE);
+      ALWAYS_OPEN_TYPE, GetAlwaysOpenCommandId());
   in_progress_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
   in_progress_download_menu_model_->AddItemWithStringId(
       TOGGLE_PAUSE, IDS_DOWNLOAD_MENU_PAUSE_ITEM);
   in_progress_download_menu_model_->AddItemWithStringId(
       SHOW_IN_FOLDER, IDS_DOWNLOAD_MENU_SHOW);
   in_progress_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
   in_progress_download_menu_model_->AddItemWithStringId(
       CANCEL, IDS_DOWNLOAD_MENU_CANCEL);
 
   return in_progress_download_menu_model_.get();
 }
 
 ui::SimpleMenuModel* DownloadShelfContextMenu::GetFinishedMenuModel() {
   if (finished_download_menu_model_)
     return finished_download_menu_model_.get();
 
   finished_download_menu_model_.reset(new ui::SimpleMenuModel(this));
 
   finished_download_menu_model_->AddItemWithStringId(
       OPEN_WHEN_COMPLETE, IDS_DOWNLOAD_MENU_OPEN);
   finished_download_menu_model_->AddCheckItemWithStringId(
-      ALWAYS_OPEN_TYPE, IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE);
-  if (DownloadItemModel(download_item_).ShouldPreferOpeningInBrowser())
+      ALWAYS_OPEN_TYPE, GetAlwaysOpenCommandId());
+  if (DownloadItemModel(download_item_).ShouldPreferOpeningInBrowser()) {
     finished_download_menu_model_->AddItemWithStringId(
         PLATFORM_OPEN, IDS_DOWNLOAD_MENU_PLATFORM_OPEN);
+  }
   finished_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
   finished_download_menu_model_->AddItemWithStringId(
       SHOW_IN_FOLDER, IDS_DOWNLOAD_MENU_SHOW);
   finished_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
   finished_download_menu_model_->AddItemWithStringId(
       CANCEL, IDS_DOWNLOAD_MENU_CANCEL);
 
   return finished_download_menu_model_.get();
 }
 
@@ skipping 37 matching lines @@
   maybe_malicious_download_menu_model_.reset(new ui::SimpleMenuModel(this));
 
   maybe_malicious_download_menu_model_->AddItemWithStringId(
       KEEP, IDS_DOWNLOAD_MENU_KEEP);
   maybe_malicious_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
   maybe_malicious_download_menu_model_->AddItemWithStringId(
       LEARN_MORE_SCANNING, IDS_DOWNLOAD_MENU_LEARN_MORE_SCANNING);
   return maybe_malicious_download_menu_model_.get();
 }
 
-ui::SimpleMenuModel*
-DownloadShelfContextMenu::GetMaliciousMenuModel() {
+ui::SimpleMenuModel* DownloadShelfContextMenu::GetMaliciousMenuModel() {
   if (malicious_download_menu_model_)
     return malicious_download_menu_model_.get();
 
   malicious_download_menu_model_.reset(new ui::SimpleMenuModel(this));
 
   DownloadItemModel download_model(download_item_);
   malicious_download_menu_model_->AddItemWithStringId(
       LEARN_MORE_SCANNING, IDS_DOWNLOAD_MENU_LEARN_MORE_SCANNING);
 
   return malicious_download_menu_model_.get();
 }
+
+int DownloadShelfContextMenu::GetAlwaysOpenCommandId() const {

[asanka, 2014/06/09 21:22:22]

Nit: This returns a string ID, not a command ID.

[Lei Zhang, 2014/06/12 05:04:26]

Done.

+#if defined(OS_WIN)
+  if (is_pdf_reader_up_to_date_)
+    return IDS_DOWNLOAD_MENU_ALWAYS_OPEN_PDF_IN_READER;
+#endif
+  return IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE;
+}
+
+#if defined(OS_WIN)
+bool DownloadShelfContextMenu::IsDownloadPdf() const {
+  base::FilePath path = download_item_->GetTargetFilePath();
+  return path.Extension() == FILE_PATH_LITERAL(".pdf");
+}
+#endif