Windows: Add an "Open in Adobe Reader" menu item for PDF files in the download shelf.

content/public/common/registry_utils_win.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_COMMON_REGISTRY_UTILS_WIN_H_
+#define CONTENT_PUBLIC_COMMON_REGISTRY_UTILS_WIN_H_
+
+#include "base/strings/string16.h"
+#include "content/common/content_export.h"
+
+#if !defined(OS_WIN)
+#error "Windows only header"
+#endif
+
+namespace base {
+class FilePath;
+}
+
+namespace content {
+
+// Windows registry path constants and utility functions.

[jam, 2014/06/19 16:37:07]

since this is generic-windows code with no content dependencies and it's used by
content & chrome, it should go into base/win/

[Lei Zhang, 2014/06/19 18:12:30]

|kRegistryAcrobat| and |kRegistryAcrobatReader| don't belong in base. Would you
prefer I put them in content/public/common or just hard code them since they're
only used in 2 places?

[Lei Zhang, 2014/06/19 18:19:44]

base/win/win_util.h seems to discourage stuffing more functions and there. Do
you have a place in mind? Should we consider just duplicating GetInstalledPath()
as well if we want to avoid exposing it via content/public? The content/ usage
will likely go away after NPAPI deprecation completes.

[Lei Zhang, 2014/06/20 06:22:51]

I decided to just leave content/ alone.

+// When NPAPI is fully removed, this can be moved into chrome/.
+
+// The key path and key name required to register applications on Windows such
+// that it can be launched from Start->Run just by name (e.g. chrome.exe).
+CONTENT_EXPORT extern const base::char16 kRegistryAppsKey[];
+CONTENT_EXPORT extern const base::char16 kRegistryPath[];
+
+// The key paths under |kRegistryAppsKey| to look for Adobe Acrobat and
+// Acrobat Reader, respectively.
+CONTENT_EXPORT extern const base::char16 kRegistryAcrobat[];
+CONTENT_EXPORT extern const base::char16 kRegistryAcrobatReader[];
+
+// Gets the installed path for a registered app. Returns true on success and
+// write the path for |app| to |out|.
+CONTENT_EXPORT bool GetInstalledPath(const base::char16* app,
+                                     base::FilePath* out);
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_COMMON_REGISTRY_UTILS_WIN_H_