ui/message_center/notification_list_unittest.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/notification_list_unittest.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/message_center/notification_list_unittest.cc

diff --git a/ui/message_center/notification_list_unittest.cc b/ui/message_center/notification_list_unittest.cc

index 7b27eb36c655f8b8abdca88c46c1a4256988fadf..637e95afaf527238508682b6860406b9f8b3d69c 100644

--- a/ui/message_center/notification_list_unittest.cc

+++ b/ui/message_center/notification_list_unittest.cc

@@ -136,9 +136,9 @@ TEST_F(NotificationListTest, Basic) {

EXPECT_EQ(2u, notification_list()->UnreadCount(blockers()));

EXPECT_TRUE(notification_list()->HasPopupNotifications(blockers()));

- EXPECT_TRUE(notification_list()->HasNotification(id0));

- EXPECT_TRUE(notification_list()->HasNotification(id1));

- EXPECT_FALSE(notification_list()->HasNotification(id1 + "foo"));

+ EXPECT_TRUE(notification_list()->GetNotificationById(id0));

+ EXPECT_TRUE(notification_list()->GetNotificationById(id1));

+ EXPECT_FALSE(notification_list()->GetNotificationById(id1 + "foo"));

EXPECT_EQ(2u, GetPopupCounts());

« no previous file with comments | « ui/message_center/notification_list.cc ('k') | no next file » | no next file with comments »