ui/message_center/cocoa/tray_view_controller.mm - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/cocoa/tray_view_controller.mm

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc ('k') | ui/message_center/fake_message_center.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/message_center/cocoa/tray_view_controller.mm

diff --git a/ui/message_center/cocoa/tray_view_controller.mm b/ui/message_center/cocoa/tray_view_controller.mm

index 674305171de4fc832ebf15b7d5a897739aeebb34..93bac88d8038178b350a286ebc564a1157ba79e6 100644

--- a/ui/message_center/cocoa/tray_view_controller.mm

+++ b/ui/message_center/cocoa/tray_view_controller.mm

@@ -661,7 +661,8 @@ const CGFloat kTrayBottomMargin = 75;

// Fade-out those notifications pending removal.

for (MCNotificationController* notification in notifications_.get()) {

- if (messageCenter_->HasNotification([notification notificationID]))

+ if (messageCenter_->FindVisibleNotificationById(

+ [notification notificationID]))

continue;

[notificationsPendingRemoval_ addObject:notification];

[animationDataArray addObject:@{