chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/display/display_preferences_unittest.cc ('k') | chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

index fd457afc7e1acf4f5d83b84ed7f66dfd7ae4f16f..1f43ccaba007f5d6cbcea842366791c629adf1c1 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

@@ -172,13 +172,13 @@ IN_PROC_BROWSER_TEST_F(NetworkPortalDetectorImplBrowserTest,

ASSERT_EQ(PortalDetectorStrategy::STRATEGY_ID_SESSION, strategy()->Id());

// No notification until portal detection is completed.

- ASSERT_FALSE(message_center()->HasNotification(kNotificationId));

+ ASSERT_FALSE(message_center()->FindVisibleNotificationById(kNotificationId));

RestartDetection();

CompleteURLFetch(net::OK, 200, NULL);

// Check that wifi is marked as behind the portal and that notification

// is displayed.

- ASSERT_TRUE(message_center()->HasNotification(kNotificationId));

+ ASSERT_TRUE(message_center()->FindVisibleNotificationById(kNotificationId));

ASSERT_EQ(NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PORTAL,

NetworkPortalDetector::Get()->GetCaptivePortalState(kWifi).status);