Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 324513006: Return 1 ony if no online device presents. (Closed)

Created:
6 years, 6 months ago by zty1
Modified:
6 years, 6 months ago
Reviewers:
navabi1, navabi, zty
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Return 1 ony if no online device presents. BUG=310881 R=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot/bb_device_status_check.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
zty
This is needed to differentiate no online device to other failures. So in recipe we ...
6 years, 6 months ago (2014-06-07 02:10:11 UTC) #1
zty
ptal
6 years, 6 months ago (2014-06-09 19:05:12 UTC) #2
navabi
lgtm
6 years, 6 months ago (2014-06-09 19:09:02 UTC) #3
navabi1
lgtm
6 years, 6 months ago (2014-06-09 19:09:21 UTC) #4
zty
The CQ bit was checked by zty@chromium.org
6 years, 6 months ago (2014-06-09 19:12:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@google.com/324513006/1
6 years, 6 months ago (2014-06-09 19:14:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 11:07:30 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 12:50:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/161034)
6 years, 6 months ago (2014-06-10 12:50:53 UTC) #9
zty1
The CQ bit was checked by zty@google.com
6 years, 6 months ago (2014-06-10 20:35:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@google.com/324513006/1
6 years, 6 months ago (2014-06-10 20:39:12 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 20:48:14 UTC) #12
Message was sent while issue was closed.
Change committed as 276131

Powered by Google App Engine
This is Rietveld 408576698