Issue 3245006: Sandboxing built-in flash...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3245006: Sandboxing built-in flash... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by cpu

Modified:
4 years ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sandboxing built-in flash This is the last change needed to have an experimental sandboxed flash for windows - Adds an export so flash can lower the token - Thightents the policy a bit - Sets a separate flash data directory. BUG=50796 TES=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57899

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -12 lines)			Patch
	M	chrome/common/sandbox_policy.cc	View		3 chunks	+9 lines, -9 lines	0 comments	Download
	M	chrome/plugin/plugin_main.cc	View		2 chunks	+32 lines, -3 lines	0 comments	Download

Trybot results: linux win mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nsylvain

LGTM. I assume you made sure that no untrusted threads were running before you call ...

4 years, 9 months ago (2010-08-29 18:44:53 UTC) #2

cpu

4 years, 9 months ago (2010-08-30 19:46:25 UTC) #3

That is an interesting point. Let me check that.


On 2010/08/29 18:44:53, nsylvain wrote:
> LGTM. I assume you made sure that no untrusted threads were running before you
> call RevertToSelf.

Expand Messages | Collapse Messages