Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/prefs/pref_hash_store.h

Issue 324493002: Move preference MACs to the protected preference stores. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment typo. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_hash_filter_unittest.cc ('k') | chrome/browser/prefs/pref_hash_store_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_hash_store.h
diff --git a/chrome/browser/prefs/pref_hash_store.h b/chrome/browser/prefs/pref_hash_store.h
index a6d97277b70b61acf57a3e3a9d64dd79bd2be7db..0fd0ae4edb2b5f31f042514d632458eee793c0b6 100644
--- a/chrome/browser/prefs/pref_hash_store.h
+++ b/chrome/browser/prefs/pref_hash_store.h
@@ -7,21 +7,22 @@
#include "base/memory/scoped_ptr.h"
+class HashStoreContents;
class PrefHashStoreTransaction;
-// Stores hashes of and verifies preference values via
-// PrefHashStoreTransactions.
+// Holds the configuration and implementation used to calculate and verify
+// preference MACs.
+// TODO(gab): Rename this class as it is no longer a store.
class PrefHashStore {
public:
virtual ~PrefHashStore() {}
// Returns a PrefHashStoreTransaction which can be used to perform a series
- // of checks/transformations on the hash store.
- virtual scoped_ptr<PrefHashStoreTransaction> BeginTransaction() = 0;
-
- // Commits this store to disk if it has changed since the last call to this
- // method.
- virtual void CommitPendingWrite() = 0;
+ // of operations on the hash store. |storage| MAY be used as the backing store
+ // depending on the implementation. Therefore the HashStoreContents used for
+ // related transactions should correspond to the same underlying data store.
+ virtual scoped_ptr<PrefHashStoreTransaction> BeginTransaction(
+ scoped_ptr<HashStoreContents> storage) = 0;
};
#endif // CHROME_BROWSER_PREFS_PREF_HASH_STORE_H_
« no previous file with comments | « chrome/browser/prefs/pref_hash_filter_unittest.cc ('k') | chrome/browser/prefs/pref_hash_store_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698