Move preference MACs to the protected preference stores.

chrome/browser/prefs/pref_hash_store_transaction.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PREFS_PREF_HASH_STORE_TRANSACTION_H_
 #define CHROME_BROWSER_PREFS_PREF_HASH_STORE_TRANSACTION_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 33 matching lines @@
   virtual ~PrefHashStoreTransaction() {}
 
   // Checks |initial_value| against the existing stored value hash.
   virtual ValueState CheckValue(
       const std::string& path, const base::Value* initial_value) const = 0;
 
   // Stores a hash of the current |value| of the preference at |path|.
   virtual void StoreHash(const std::string& path,
                          const base::Value* value) = 0;
 
+  virtual const base::Value* GetHash(const std::string& path) const = 0;
+  virtual void ImportHash(const std::string& path, const base::Value* hash) = 0;
+  virtual void ClearHash(const std::string& path) = 0;
+  virtual bool StampSuperMac() = 0;

[gab, 2014/06/06 21:54:59]

Add those methods at the bottom of this file (keeping CheckValue/StoreHash and
CheckSplitValue/StoreSplitHash together makes more sense than adding this in
between).

And add comments for them.

[erikwright (departed), 2014/06/10 20:27:47]

Done.

+
   // Checks |initial_value| against the existing stored hashes for the split
   // preference at |path|. |initial_split_value| being an empty dictionary or
   // NULL is equivalent. |invalid_keys| must initially be empty. |invalid_keys|
   // will not be modified unless the return value is CHANGED, in which case it
   // will be filled with the keys that are considered invalid (unknown or
   // changed).
   virtual ValueState CheckSplitValue(
       const std::string& path,
       const base::DictionaryValue* initial_split_value,
       std::vector<std::string>* invalid_keys) const = 0;
 
   // Stores hashes for the |value| of the split preference at |path|.
   // |split_value| being an empty dictionary or NULL is equivalent.
   virtual void StoreSplitHash(
       const std::string& path,
       const base::DictionaryValue* split_value) = 0;
 };
 
 #endif  // CHROME_BROWSER_PREFS_PREF_HASH_STORE_TRANSACTION_H_