Move preference MACs to the protected preference stores.

chrome/browser/prefs/pref_hash_store.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PREFS_PREF_HASH_STORE_H_
 #define CHROME_BROWSER_PREFS_PREF_HASH_STORE_H_
 
 #include "base/memory/scoped_ptr.h"
 
 class PrefHashStoreTransaction;
 
+namespace base {
+class DictionaryValue;
+}  // namespace base
+
 // Stores hashes of and verifies preference values via
 // PrefHashStoreTransactions.

[gab, 2014/06/13 01:57:43]

Update this comment to state that this PrefHashStore may also hold state between
transactions (otherwise its essentially just a logic object with from the
description).

[erikwright (departed), 2014/06/16 20:51:26]

Corrected it to refer specifically to this being a configuration/implementation
object.

 class PrefHashStore {
  public:
   virtual ~PrefHashStore() {}
 
   // Returns a PrefHashStoreTransaction which can be used to perform a series
   // of checks/transformations on the hash store.

[gab, 2014/06/13 01:57:43]

Modify this comment to state that all transformations performed on the
PrefHashStoreTransaction returned will be based on |storage|.

[erikwright (departed), 2014/06/16 20:51:26]

In tests we may ignore |storage| in order to reproduce a legacy hash store in
Local State. So I updated the comment but explicitly allowed for alternatives.

-  virtual scoped_ptr<PrefHashStoreTransaction> BeginTransaction() = 0;
-
-  // Commits this store to disk if it has changed since the last call to this
-  // method.
-  virtual void CommitPendingWrite() = 0;
+  virtual scoped_ptr<PrefHashStoreTransaction> BeginTransaction(
+      base::DictionaryValue* storage) = 0;

[gab, 2014/06/13 01:57:43]

I think it would make sense for this to take a HashStoreContents* instead of
directly taking a base::DictionaryValue* (it internally immediately stores this
pointer in a DictionaryHashStoreContents anyways and it would make it such that
only PrefHashFilter and TrackedPreferencesMigrator have to be intimately aware
that the hashes are stored in the prefs dictionary).

[erikwright (departed), 2014/06/16 20:51:26]

Done.

 };
 
 #endif  // CHROME_BROWSER_PREFS_PREF_HASH_STORE_H_