Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 324483003: cc: Removed LCD text settings from the impl side. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index d380cfecd2cc47904b37217eb0136513f6119fbd..6a196d33722ecd966a2b16ac131c66d00db8d7c9 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -1648,8 +1648,8 @@ TEST_F(PictureLayerImplTest, ActivateUninitializedLayer) {
// by a sync from the active layer. This could happen because if the
// pending layer has not been post-commit initialized it will attempt
// to sync from the active layer.
- bool default_lcd_text_setting = pending_layer_->is_using_lcd_text();
- pending_layer_->force_set_lcd_text(!default_lcd_text_setting);
+ // bool default_lcd_text_setting = pending_layer_->is_using_lcd_text();
alokp 2014/06/06 22:37:40 enne: LCD text state is going away. Any suggestion
enne (OOO) 2014/06/09 22:58:39 Looking at SyncFromActiveLayer, maybe one of the r
+ // pending_layer_->force_set_lcd_text(!default_lcd_text_setting);
EXPECT_TRUE(pending_layer_->needs_post_commit_initialization());
host_impl_.ActivatePendingTree();
@@ -1658,7 +1658,7 @@ TEST_F(PictureLayerImplTest, ActivateUninitializedLayer) {
host_impl_.active_tree()->LayerById(id_));
EXPECT_EQ(0u, active_layer_->num_tilings());
- EXPECT_EQ(!default_lcd_text_setting, active_layer_->is_using_lcd_text());
+ // EXPECT_EQ(!default_lcd_text_setting, active_layer_->is_using_lcd_text());
EXPECT_FALSE(active_layer_->needs_post_commit_initialization());
}
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698