Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 324483003: cc: Removed LCD text settings from the impl side. (Closed)

Created:
6 years, 6 months ago by alokp
Modified:
6 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Visibility:
Public.

Description

cc: Removed LCD text settings from the impl side. Now that the SkPicture is recorded with the correct LCD setting, there is no need to have any LCD text related setting on the impl side. BUG=368513 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276918

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : updated unittest #

Total comments: 2

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -249 lines) Patch
M cc/layers/picture_layer_impl.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 7 chunks +0 lines, -23 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M cc/resources/prioritized_tile_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_mode.h View 1 chunk +3 lines, -6 lines 0 comments Download
M cc/resources/raster_mode.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/resources/tile.h View 2 chunks +1 line, -12 lines 0 comments Download
M cc/resources/tile.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M cc/resources/tile_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 1 2 3 3 chunks +1 line, -16 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 2 3 3 chunks +1 line, -155 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
alokp
Follow-up patch for https://codereview.chromium.org/315393002/ https://codereview.chromium.org/324483003/diff/1/cc/layers/picture_layer_impl_unittest.cc File cc/layers/picture_layer_impl_unittest.cc (right): https://codereview.chromium.org/324483003/diff/1/cc/layers/picture_layer_impl_unittest.cc#newcode1651 cc/layers/picture_layer_impl_unittest.cc:1651: // bool default_lcd_text_setting = pending_layer_->is_using_lcd_text(); ...
6 years, 6 months ago (2014-06-06 22:37:40 UTC) #1
enne (OOO)
https://codereview.chromium.org/324483003/diff/1/cc/layers/picture_layer_impl_unittest.cc File cc/layers/picture_layer_impl_unittest.cc (right): https://codereview.chromium.org/324483003/diff/1/cc/layers/picture_layer_impl_unittest.cc#newcode1651 cc/layers/picture_layer_impl_unittest.cc:1651: // bool default_lcd_text_setting = pending_layer_->is_using_lcd_text(); Looking at SyncFromActiveLayer, maybe ...
6 years, 6 months ago (2014-06-09 22:58:39 UTC) #2
alokp
PTAL
6 years, 6 months ago (2014-06-11 06:46:23 UTC) #3
enne (OOO)
lgtm
6 years, 6 months ago (2014-06-11 17:27:48 UTC) #4
vmpstr
lgtm2 https://codereview.chromium.org/324483003/diff/40001/cc/resources/tile.h File cc/resources/tile.h (right): https://codereview.chromium.org/324483003/diff/40001/cc/resources/tile.h#newcode151 cc/resources/tile.h:151: int flags); Is this ever not 0 nowadays? ...
6 years, 6 months ago (2014-06-11 18:36:26 UTC) #5
alokp
https://codereview.chromium.org/324483003/diff/40001/cc/resources/tile.h File cc/resources/tile.h (right): https://codereview.chromium.org/324483003/diff/40001/cc/resources/tile.h#newcode151 cc/resources/tile.h:151: int flags); On 2014/06/11 18:36:26, vmpstr wrote: > Is ...
6 years, 6 months ago (2014-06-11 20:02:06 UTC) #6
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 6 months ago (2014-06-12 21:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/324483003/80001
6 years, 6 months ago (2014-06-12 21:16:38 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 04:07:51 UTC) #9
Message was sent while issue was closed. 
Change committed as 276918

Powered by Google App Engine
This is Rietveld 408576698