Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 324453003: PPAPI: Remove PP_ALLOW_THIS_IN_INITIALIZER_LIST (Closed)

Created:
6 years, 6 months ago by dmichael (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
teravest
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org, tfarina
Visibility:
Public.

Description

PPAPI: Remove PP_ALLOW_THIS_IN_INITIALIZER_LIST BUG=380827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
M ppapi/api/pp_macros.idl View 1 chunk +0 lines, -16 lines 0 comments Download
M ppapi/c/pp_macros.h View 1 chunk +0 lines, -16 lines 0 comments Download
M ppapi/tests/test_flash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash_drm.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash_message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/utility/websocket/websocket_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmichael (off chromium)
6 years, 6 months ago (2014-06-06 16:01:47 UTC) #1
teravest
lgtm
6 years, 6 months ago (2014-06-06 16:04:46 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 6 months ago (2014-06-06 16:49:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/324453003/1
6 years, 6 months ago (2014-06-06 16:50:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 19:18:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:37:47 UTC) #6
Message was sent while issue was closed.
Change committed as 275514

Powered by Google App Engine
This is Rietveld 408576698