Use new SkBaseMutex::assertHeld() in DiscardableMemoryPool

Use new SkBaseMutex::assertHeld() in DiscardableMemoryPool

Committed: https://skia.googlesource.com/skia/+/9b7906672eb6794497d560761aa8bab824a13a90

[hal.canary, 2014-06-11 15:47:22]

ptal

[mtklein, 2014-06-11 15:59:04]

https://codereview.chromium.org/324413003/diff/20001/src/lazy/SkDiscardableMe...
File src/lazy/SkDiscardableMemoryPool.cpp (right):

https://codereview.chromium.org/324413003/diff/20001/src/lazy/SkDiscardableMe...
src/lazy/SkDiscardableMemoryPool.cpp:148: #ifdef SK_DEBUG
Doesn't really need the SK_DEBUG check?

[hal.canary, 2014-06-11 16:17:32]

https://codereview.chromium.org/324413003/diff/20001/src/lazy/SkDiscardableMe...
File src/lazy/SkDiscardableMemoryPool.cpp (right):

https://codereview.chromium.org/324413003/diff/20001/src/lazy/SkDiscardableMe...
src/lazy/SkDiscardableMemoryPool.cpp:148: #ifdef SK_DEBUG
On 2014/06/11 15:59:04, mtklein wrote:
> Doesn't really need the SK_DEBUG check?

Yes, because in release, you could call NULL->assertHeld();

[hal.canary, 2014-06-11 16:18:58]

On 2014/06/11 16:17:32, Hal Canary wrote:
>
https://codereview.chromium.org/324413003/diff/20001/src/lazy/SkDiscardableMe...
> File src/lazy/SkDiscardableMemoryPool.cpp (right):
> 
>
https://codereview.chromium.org/324413003/diff/20001/src/lazy/SkDiscardableMe...
> src/lazy/SkDiscardableMemoryPool.cpp:148: #ifdef SK_DEBUG
> On 2014/06/11 15:59:04, mtklein wrote:
> > Doesn't really need the SK_DEBUG check?
> 
> Yes, because in release, you could call NULL->assertHeld();

Wait, that was stupid.

[mtklein, 2014-06-11 16:21:32]

lgtm

[mtklein, 2014-06-11 16:28:21]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-06-11 16:29:29]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/324413003/40001

[commit-bot: I haz the power, 2014-06-11 16:40:29]

Change committed as 9b7906672eb6794497d560761aa8bab824a13a90