Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Issue 324413002: Revert of RenderTextHarfBuzz: Decide run direction by BiDi embedding level (Closed)

Created:
6 years, 6 months ago by ckocagil
Modified:
6 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of RenderTextHarfBuzz: Decide run direction by BiDi embedding level (https://codereview.chromium.org/326123003/) Reason for revert: Memory leak: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/3570/steps/ui_unittests/logs/HarfBuzz_RunDirection Original issue's description: > RenderTextHarfBuzz: Decide run direction by BiDi embedding level > > BUG=382178 > NOTRY=true > R=msw > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276379 TBR=msw@chromium.org NOTREECHECKS=true NOTRY=true BUG=382178 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -55 lines) Patch
M ui/gfx/render_text_harfbuzz.h View 2 chunks +1 line, -4 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 3 chunks +41 lines, -39 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ckocagil
Created Revert of RenderTextHarfBuzz: Decide run direction by BiDi embedding level
6 years, 6 months ago (2014-06-11 14:21:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/324413002/1
6 years, 6 months ago (2014-06-11 14:23:24 UTC) #2
commit-bot: I haz the power
Change committed as 276387
6 years, 6 months ago (2014-06-11 14:25:20 UTC) #3
msw
6 years, 6 months ago (2014-06-11 16:44:43 UTC) #4
Message was sent while issue was closed.
Hmm, do those leaks occur anyway, and the test just exposed them? lgtm

Powered by Google App Engine
This is Rietveld 408576698