Issue 324403007: Remove RenderViewImpl::FrameDidCommitProvisionalLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324403007: Remove RenderViewImpl::FrameDidCommitProvisionalLoad (Closed)

Created:
6 years, 6 months ago by nasko

Modified:
6 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove RenderViewImpl::FrameDidCommitProvisionalLoad BUG=304341 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276712

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -35 lines)			Patch
M	content/renderer/render_frame_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	4 chunks	+22 lines, -3 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	3 chunks	+5 lines, -26 lines	0 comments	Download

Total messages: 6 (0 generated)

nasko

Hey John, Another small cleanup to remove a method mostly used for notifying RVOs. Can ...

6 years, 6 months ago (2014-06-11 21:57:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/324403007/1

6 years, 6 months ago (2014-06-12 07:49:21 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 6 months ago (2014-06-12 12:22:37 UTC) #5

Message was sent while issue was closed.

Change committed as 276712