Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: build/config/BUILD.gn

Issue 324403006: Add a new FORCE_DETERMINISTIC_BUILD define. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to force_deterministic_build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 3fb9c9b1e855e2726ab3b36ea073f72cd0ec3fe8..e803ae3d10318a84d8ee588a99b17c01af0f256d 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -12,6 +12,12 @@ declare_args() {
# that is normally turned on for Debug builds. These are generally useful for
# catching bugs but in some cases may cause conflicts or excessive slowness.
disable_iterator_debugging = false
+
+ # Set to true to force deterministic builds (this isn't working yet but this
+ # flag will help us to get there). See http://crbug.com/314403.
+ # TODO(sebmarchand): Update this comment once this flag guarantee a
+ # deterministic build.
+ force_deterministic_build = false
}
# TODO(brettw) Most of these should be removed. Instead of global feature
@@ -71,6 +77,9 @@ config("feature_flags") {
if (enable_spellcheck) {
defines += [ "ENABLE_SPELLCHECK=1" ]
}
+ if (force_deterministic_build) {
+ defines += [ "FORCE_DETERMINISTIC_BUILD" ]
+ }
if (use_udev) {
# TODO(brettw) should probably be "=1".
defines += [ "USE_UDEV" ]
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698