Issue 324403003: Fixed flooring division by a power of 2, once again...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324403003: Fixed flooring division by a power of 2, once again... (Closed)

Created:
6 years, 6 months ago by Sven Panne

Modified:
6 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed flooring division by a power of 2, once again... Avoid right shifts by zero bits: On ARM it actually means shifting by 32 bits (correctness issue) and on other platforms they are useless (performance issue). This is fix for the fix in r20544. BUG=v8:3259 LOG=y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21769

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -30 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+9 lines, -7 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 chunk	+9 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 6 months ago (2014-06-11 13:29:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21769 (presubmit successful).

Expand Messages | Collapse Messages