Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 324403002: Do not define OS_CHROMEOS for untrusted NaCl code (Closed)

Created:
6 years, 6 months ago by hamaji
Modified:
6 years, 6 months ago
Reviewers:
Mark Seaborn, awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Do not define OS_CHROMEOS for untrusted NaCl code so that we do not need !defined(__native_client) for Chrome OS specific clock ID. TEST=Manually checked untrusted code does not have OS_CHROMEOS and trusted code does have it. TEST=trybots BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276985

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M base/time/time_posix.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M build/common.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hamaji
6 years, 6 months ago (2014-06-12 00:49:50 UTC) #1
Mark Seaborn
LGTM, assuming you've checked that the #define is set/unset properly for trusted and untrusted code ...
6 years, 6 months ago (2014-06-12 04:30:37 UTC) #2
hamaji
Yes, I have updated the description. +ajwong for base owner review
6 years, 6 months ago (2014-06-12 06:44:57 UTC) #3
awong
LGTM
6 years, 6 months ago (2014-06-12 19:00:49 UTC) #4
hamaji
The CQ bit was checked by hamaji@chromium.org
6 years, 6 months ago (2014-06-13 03:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/324403002/20001
6 years, 6 months ago (2014-06-13 03:55:10 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 09:28:47 UTC) #7
Message was sent while issue was closed.
Change committed as 276985

Powered by Google App Engine
This is Rietveld 408576698