Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.h

Issue 324393002: Extension Toolbar redesign, part 1 (overflow) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing gypi change Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.h
diff --git a/chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.h b/chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..dcbc18f680545c3688f26a5a20794c9a783e544a
--- /dev/null
+++ b/chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.h
@@ -0,0 +1,33 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SYNTHESIZE_BROWSER_ACTION_HANDLER_H_
+#define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SYNTHESIZE_BROWSER_ACTION_HANDLER_H_
+
+#include <string>
+
+#include "extensions/common/manifest_handler.h"
+
+namespace extensions {
+
+// Ensures that an extension that doesn't specify any icon in its manifest, gets
+// a browser action icon, that we can hang UI off of.
+// TODO(finnur): Combine the logic, as suggested in review 324393002.
+class SynthesizeBrowserActionHandler : public ManifestHandler {
+ public:
+ SynthesizeBrowserActionHandler();
+ virtual ~SynthesizeBrowserActionHandler();
+
+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;
+ virtual bool AlwaysParseForType(Manifest::Type type) const OVERRIDE;
+
+ private:
+ virtual const std::vector<std::string> Keys() const OVERRIDE;
+
+ DISALLOW_COPY_AND_ASSIGN(SynthesizeBrowserActionHandler);
+};
+
+} // namespace extensions
+
+#endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SYNTHESIZE_BROWSER_ACTION_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698