Extension Toolbar redesign, part 1 (overflow)

chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

Index: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
diff --git a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..40ed019e19e186f79433210beb9304fe4ec9f843
--- /dev/null
+++ b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
@@ -0,0 +1,33 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_
+
+#include "ui/views/view.h"
+
+class Browser;
+class BrowserActionsContainer;
+
+// ExtensionToolbarMenuView is the view containing the extension actions that
+// overflowed from the BrowserActionsContainer, and is contained in and owned by
+// the wrench menu.
+class ExtensionToolbarMenuView : public views::View {
+ public:
+  explicit ExtensionToolbarMenuView(Browser* browser);
+  virtual ~ExtensionToolbarMenuView();
+
+  // Overridden from View.

[Peter Kasting, 2014/06/30 23:36:34]

Nit: We're wildly inconsistent about what to put in this comment, but personally
I prefer just "views::View:" which is as short as possible.  (Use the same name
the class parent declaration above does.)

[Finnur, 2014/07/02 16:59:57]

Weird. I switched my preference from this to views::View: myself at some point
in the past, but this must be that saying about the old dog, new tricks, and all
that. Anyway -- changed.

+  virtual gfx::Size GetPreferredSize() const OVERRIDE;
+  virtual void Layout() OVERRIDE;
+
+ private:
+  Browser* browser_;
+

[Peter Kasting, 2014/06/30 23:36:34]

Nit: Unnecessary blank line

[Finnur, 2014/07/02 16:59:57]

Done.

+  BrowserActionsContainer* container_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarMenuView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_