Extension Toolbar redesign, part 1 (overflow)

chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.cc

Index: chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.cc b/chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9149d0027c3f498e028ac4ad645726967f7a71ef
--- /dev/null
+++ b/chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.cc
@@ -0,0 +1,47 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/extensions/manifest_handlers/synthesize_browser_action_handler.h"
+
+#include "chrome/common/extensions/api/extension_action/action_info.h"
+#include "extensions/common/feature_switch.h"
+#include "extensions/common/manifest_constants.h"
+
+namespace extensions {
+
+SynthesizeBrowserActionHandler::SynthesizeBrowserActionHandler() {
+}
+
+SynthesizeBrowserActionHandler::~SynthesizeBrowserActionHandler() {
+}
+
+bool SynthesizeBrowserActionHandler::Parse(Extension* extension,
+                                           base::string16* error) {
+  if (!extensions::FeatureSwitch::extension_action_redesign()->IsEnabled())
+    return true;  // Do nothing.
+
+  if (extension->location() == Manifest::COMPONENT ||
+      extension->location() == Manifest::EXTERNAL_COMPONENT)
+    return true;  // Return no error (we're done).
+
+  if (extension->manifest()->HasKey(manifest_keys::kSynthesizeBrowserAction))
+    return false;  // This key is reserved, no extension should be using it.
+
+  if (!extension->manifest()->HasKey(manifest_keys::kBrowserAction) &&
+      !extension->manifest()->HasKey(manifest_keys::kPageAction))

[Devlin, 2014/06/26 16:29:13]

Page actions are designed to only show some of the time, so if an extension has
a page action, it won't show up in the new menu (even though an extension with
no browser action and no page action will).  I think it'd be better to have a
browser action per extension, and just risk showing both a page action and a
browser action.  I don't feel too strongly about it though - either way, we have
to address it later.

[Finnur, 2014/06/27 14:23:38]

I thought about that, and wasn't sure what to do here. I was actually more
worried about having two icons for the same extensions in the browser action
container (when we merge page and browser actions), but I guess I'll just add a
reminder here.

+    ActionInfo::SetBrowserActionInfo(extension, new ActionInfo());
+
+  return true;
+}
+
+bool SynthesizeBrowserActionHandler::AlwaysParseForType(
+    Manifest::Type type) const {
+  return type == Manifest::TYPE_EXTENSION;
+}
+
+const std::vector<std::string> SynthesizeBrowserActionHandler::Keys() const {
+  return SingleKey(manifest_keys::kSynthesizeBrowserAction);
+}
+
+}  // namespace extensions