Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 324383005: Rossberg's suggested changes to the LookupIterator. (Closed)

Created:
6 years, 6 months ago by Toon Verwaest
Modified:
6 years, 6 months ago
Reviewers:
Igor Sheludko, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Rossberg's suggested changes to the LookupIterator. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21778

Patch Set 1 #

Patch Set 2 : Addressed ishell's extra comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -43 lines) Patch
M src/lookup.h View 1 8 chunks +19 lines, -19 lines 0 comments Download
M src/lookup.cc View 1 4 chunks +18 lines, -19 lines 0 comments Download
M src/objects.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 6 months ago (2014-06-11 17:32:44 UTC) #1
Igor Sheludko
lgtm
6 years, 6 months ago (2014-06-11 18:01:10 UTC) #2
Toon Verwaest
6 years, 6 months ago (2014-06-11 18:02:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698